Reaction Codex Fix for Unstable Ingredients #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's almost certainly more reagents that would need unstable_temperature. and I still feel silly having that variable only get used by the codex.
|
Leaving this as a draft for now - I still need to go over all the reagents to make sure there aren't similar cases I forgot about |
it SEEMS like these are the only chemicals that'd benefit from having unstable_temperature
Co-authored-by: tgstation-server <[email protected]>
there's almost certainly more reagents that would need unstable_temperature. and I still feel silly having that variable only get used by the codex.
it SEEMS like these are the only chemicals that'd benefit from having unstable_temperature
…dalusdock into codex-plasma-boiling
|
guh. accidental push so I suppose I am going with it now. this branch was rebased to the one in #855 |
I forgot about results potentially being unstable. now the codex tells you hot nitroglycerin might be unwise!
|
the main problem this was meant to solve is being removed - so I'm closing this and opening a fresh PR for thermic info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reaction codex entries now reflect cases where their ingredients change at certain temperatures, such as plasma turning to gas or water freezing into ice.
Also adds a label for when reactions are exothermic/endothermic, so it's more clear how a reaction will affect temperature.
Why It's Good For The Game
Fixes #851, because It's nice to know that when you fill chemistry with plasma trying to make dexalin, it isn't the codex's fault for having the wrong temperatures!
Changelog
🆑
qol: reaction codex entries now show you if a reaction is endo/exothermic, and by how much
fix: reaction codex entries now reflect the temperatures required by its ingredients
/:cl: